Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753049Ab1FNOIv (ORCPT ); Tue, 14 Jun 2011 10:08:51 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:35822 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751839Ab1FNOIs convert rfc822-to-8bit (ORCPT ); Tue, 14 Jun 2011 10:08:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=fiy/zWfORkkmBk+NcM/dZpIcPUuCirAyL/y5I9WpvqeZEOuLazWO4nCzg+I1HryXQg iOozXRPA+jahqmWES8Fx3i7PXkPRvqmjYACYXyQZS/z9zFhO5Rb25lQ4VSEMYY7M6j4G BtQf6bvbLniI6hBqUUMIgKHSvQb7HtGbDmOIY= MIME-Version: 1.0 In-Reply-To: <1308060028.18987.6.camel@Joe-Laptop> References: <486a21b708a9dce0c1c0059a21a2f9b66dac9e3c.1308024069.git.joe@perches.com> <1308060028.18987.6.camel@Joe-Laptop> Date: Tue, 14 Jun 2011 16:02:30 +0200 X-Google-Sender-Auth: MBrBx9QVdu4kDCg7nV6MjdNwX4s Message-ID: Subject: Re: [PATCH net-next 2/2] drivers/net: Remove casts of void * From: Geert Uytterhoeven To: Joe Perches Cc: netdev@vger.kernel.org, Arnaldo Carvalho de Melo , Jay Cliburn , Chris Snook , Jie Yang , Sathya Perla , Subbu Seetharaman , Ajit Khaparde , Rasesh Mody , Debashis Dutt , Sjur Braendeland , Divy Le Ray , Breno Leitao , Amit Kumar Salecha , Ron Mercer , linux-driver@qlogic.com, Anirban Chakraborty , Jon Mason , Solarflare linux maintainers , Steve Hodgson , Ben Hutchings , Daniele Venzano , David Dillow , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2259 Lines: 63 Hi Joe, On Tue, Jun 14, 2011 at 16:00, Joe Perches wrote: > On Tue, 2011-06-14 at 11:21 +0200, Geert Uytterhoeven wrote: >> On Tue, Jun 14, 2011 at 06:02, Joe Perches wrote: >> > Unnecessary casts of void * clutter the code. >> > --- a/drivers/net/a2065.c >> > +++ b/drivers/net/a2065.c >> > @@ -426,7 +426,7 @@ static irqreturn_t lance_interrupt (int irq, void *dev_id) >> >        volatile struct lance_regs *ll; >> >        int csr0; >> > >> > -       dev = (struct net_device *) dev_id; >> > +       dev = dev_id; >> >> I think it would look better if you merge this line with the line that >> defines "dev". > > I think so too, but I also think it should look like below > and that's something better done in a separate pass, don't > you think? > > diff --git a/drivers/net/a2065.c b/drivers/net/a2065.c > index deaa8bc..25ea98a 100644 > --- a/drivers/net/a2065.c > +++ b/drivers/net/a2065.c > @@ -421,16 +421,11 @@ static int lance_tx (struct net_device *dev) > >  static irqreturn_t lance_interrupt (int irq, void *dev_id) >  { > -       struct net_device *dev; > -       struct lance_private *lp; > -       volatile struct lance_regs *ll; > +       struct net_device *dev = dev_id; > +       struct lance_private *lp = netdev_priv(dev); > +       volatile struct lance_regs *ll = lp->ll; >        int csr0; > > -       dev = (struct net_device *) dev_id; > - > -       lp = netdev_priv(dev); > -       ll = lp->ll; > - >        ll->rap = LE_CSR0;              /* LANCE Controller Status */ >        csr0 = ll->rdp; Definitely better! Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/