Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752317Ab1FNQnz (ORCPT ); Tue, 14 Jun 2011 12:43:55 -0400 Received: from mail.perches.com ([173.55.12.10]:2997 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370Ab1FNQnx (ORCPT ); Tue, 14 Jun 2011 12:43:53 -0400 Subject: Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void * From: Joe Perches To: Pavel Roskin Cc: netdev@vger.kernel.org, Intel Linux Wireless , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, "John W. Linville" , Jouni Malinen , Senthil Balasubramanian , ath9k-devel@venema.h4ckr.net, Wey-Yi Guy , Vasanthakumar Thiagarajan , Christian Lamparter , Stanislaw Gruszka In-Reply-To: <4DF78CEC.70409@gnu.org> References: <337c22b774ff7f007b90b266b25c9a33ff555c48.1308024069.git.joe@perches.com> <4DF78CEC.70409@gnu.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 14 Jun 2011 09:43:51 -0700 Message-ID: <1308069831.21026.9.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 32 On Tue, 2011-06-14 at 12:31 -0400, Pavel Roskin wrote: > On 06/14/2011 12:02 AM, Joe Perches wrote: > > /* Get the message ID */ > > - msg_id = (__be16 *) ((void *) htc_hdr + > > - sizeof(struct htc_frame_hdr)); > > + msg_id = (void *)htc_hdr + sizeof(struct htc_frame_hdr); > I would never do stuff like this without verifying by sparse that no > warnings are introduced. I did that. I believe there are no new warnings. > Sparse warnings should be avoided to keep sparse checks useful. > Otherwise, important warnings would drown in the noise. $ make allyesconfig $ git log -1 --pretty=oneline drivers/net/wireless/ath/ath9k/htc_hst.c 337c22b774ff7f007b90b266b25c9a33ff555c48 wireless: Remove casts of void * $ make C=2 drivers/net/wireless/ath/ath9k/htc_hst.o make[1]: Nothing to be done for `all'. CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CHECK scripts/mod/empty.c CHECK drivers/net/wireless/ath/ath9k/htc_hst.c CC drivers/net/wireless/ath/ath9k/htc_hst.o $ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/