Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242Ab1FNTT3 (ORCPT ); Tue, 14 Jun 2011 15:19:29 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:54234 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509Ab1FNTT2 convert rfc822-to-8bit (ORCPT ); Tue, 14 Jun 2011 15:19:28 -0400 MIME-Version: 1.0 In-Reply-To: <201106142017.41558.arnd@arndb.de> References: <1307079502-6326-1-git-send-email-jim.cromie@gmail.com> <201106141607.02171.arnd@arndb.de> <201106142017.41558.arnd@arndb.de> From: Grant Likely Date: Tue, 14 Jun 2011 13:19:08 -0600 X-Google-Sender-Auth: txPQKcjFkxMnwARhL_oYJWuIz7w Message-ID: Subject: Re: [PATCH] fix bogus use of rc = alloc_chrdev_region() To: Arnd Bergmann Cc: Greg KH , Jim Cromie , linux-kernel@vger.kernel.org, rpjday@crashcourse.ca Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 23 On Tue, Jun 14, 2011 at 12:17 PM, Arnd Bergmann wrote: > On Tuesday 14 June 2011 18:23:50 Grant Likely wrote: >> On Tue, Jun 14, 2011 at 8:07 AM, Arnd Bergmann wrote: >> >> > On the topic of drivers/char/{nsc_gpio,pc8736x_gpio,scx200_gpio}, I wonder >> > if we should move them to drivers/gpio/nsc_gpio despite the fact that they >> > use a different (older) interface than all the other gpio drivers. >> >> I have no problem with moving them into drivers/gpio. ?When you do, >> please rename then drivers/gpio/gpio-*.c > > Ok. Should they be in a subdirectory drivers/gpio/nsc_gpio/gpio_* for the > nonstandard API or do you prefer them to live amongst the regular ones?' I only see one files per non-standard driver. I wouldn't bother with subdirectories. Just put them in with the general population. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/