Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754460Ab1FOBUV (ORCPT ); Tue, 14 Jun 2011 21:20:21 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:50765 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752837Ab1FOBUU (ORCPT ); Tue, 14 Jun 2011 21:20:20 -0400 Date: Tue, 14 Jun 2011 18:19:55 -0700 From: Andrew Morton To: KAMEZAWA Hiroyuki Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "nishimura@mxp.nes.nec.co.jp" , "bsingharora@gmail.com" , "hannes@cmpxchg.org" , Michal Hocko , Ying Han Subject: Re: [BUGFIX][PATCH 5/5] memcg: fix percpu cached charge draining frequency Message-Id: <20110614181955.edbed282.akpm@linux-foundation.org> In-Reply-To: <20110615090935.d5789b58.kamezawa.hiroyu@jp.fujitsu.com> References: <20110613120054.3336e997.kamezawa.hiroyu@jp.fujitsu.com> <20110613121648.3d28afcd.kamezawa.hiroyu@jp.fujitsu.com> <20110613142501.15e14b2f.akpm@linux-foundation.org> <20110615090935.d5789b58.kamezawa.hiroyu@jp.fujitsu.com> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 707 Lines: 17 On Wed, 15 Jun 2011 09:09:35 +0900 KAMEZAWA Hiroyuki wrote: > > I made this static. If we later wish to give it kernel-wide scope then > > "percpu_charge_mutex" will not be a good choice of name. > > Thank you. > And, yes..... memcg_cached_charge_mutex ? I don't see a need to rename the mutex unless we change it to have kernel-wide scope. Given that it's presently static to memcontrol.c, it's obviously part of memcg ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/