Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751747Ab1FOFhv (ORCPT ); Wed, 15 Jun 2011 01:37:51 -0400 Received: from mail-gx0-f174.google.com ([209.85.161.174]:46632 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453Ab1FOFht convert rfc822-to-8bit (ORCPT ); Wed, 15 Jun 2011 01:37:49 -0400 MIME-Version: 1.0 In-Reply-To: References: <1305657064-4531-1-git-send-email-johnlinn@comcast.net> From: Grant Likely Date: Tue, 14 Jun 2011 23:37:29 -0600 X-Google-Sender-Auth: gv2FftrzCzpkp5nMu0FqiFVoo3s Message-ID: Subject: Re: [PATCH V2] ARM: Xilinx: Adding Xilinx board support To: Barry Song <21cnbao@gmail.com> Cc: johnlinn@comcast.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@arm.linux.org.uk, arnd@arndb.de, nicolas.pitre@linaro.org, John Linn Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 37 On Tue, Jun 14, 2011 at 9:23 PM, Barry Song <21cnbao@gmail.com> wrote: > 2011/5/18 ?: >> +static struct of_device_id zynq_of_bus_ids[] __initdata = { >> + ? ? ? { .compatible = "simple-bus", }, >> + ? ? ? {} >> +}; >> + >> +/** >> + * xilinx_init_machine() - System specific initialization, intended to be >> + * ? ? ? ? ? ? ? ? ? ? ? ?called from board specific initialization. >> + */ >> +void __init xilinx_init_machine(void) >> +{ >> +#ifdef CONFIG_CACHE_L2X0 >> + ? ? ? /* >> + ? ? ? ?* 64KB way size, 8-way associativity, parity disabled >> + ? ? ? ?*/ >> + ? ? ? l2x0_init(PL310_L2CC_BASE, 0x02060000, 0xF0F0FFFF); >> +#endif >> + >> + ? ? ? of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL); >> +} > > it looks to me a common machine init function is calling a > chip/board-special device probing. xilinx_init_machine ?is calling > zynq_of_bus_ids. what will happen if we add a new different with zynq? The bus_ids are actually pretty generic. I've got a patch in my tree which I'll be posting soon that creates a generic bus id table that most platforms can use. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/