Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753517Ab1FOHtl (ORCPT ); Wed, 15 Jun 2011 03:49:41 -0400 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:32703 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753007Ab1FOHti (ORCPT ); Wed, 15 Jun 2011 03:49:38 -0400 X-Greylist: delayed 1172 seconds by postgrey-1.27 at vger.kernel.org; Wed, 15 Jun 2011 03:49:38 EDT Date: Wed, 15 Jun 2011 16:30:04 +0900 Message-ID: <874o3rimbn.wl%ysato@users.sourceforge.jp> From: Yoshinori Sato To: uclinux-dev@uclinux.org, linux-kernel@vger.kernel.org Subject: [PATCH] binfmt_flat: missing argv table User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/23.3 (i486-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 899 Lines: 28 "put_user" is multiple times evalute on argument (in asm-generic/uaccess.h). So this code building argv table include gabage. Signed-off-by: Yoshinori Sato diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index 811384b..127a198 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -144,7 +144,7 @@ static unsigned long create_flat_tables( put_user(argc, sp); current->mm->arg_start = (unsigned long) p; while (argc-->0) { - put_user((unsigned long) p, argv++); + put_user((unsigned long) p, argv); argv++; do { get_user(dummy, p); p++; } while (dummy); -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/