Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551Ab1FOOgl (ORCPT ); Wed, 15 Jun 2011 10:36:41 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:44134 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754966Ab1FOOgh convert rfc822-to-8bit (ORCPT ); Wed, 15 Jun 2011 10:36:37 -0400 From: "Hiremath, Vaibhav" To: Vladimir Pantelic , Kernel development list CC: "linux-omap@vger.kernel.org" Date: Wed, 15 Jun 2011 20:06:32 +0530 Subject: RE: [PATCH] omap v4l2: fix wrong resizer calculation Thread-Topic: [PATCH] omap v4l2: fix wrong resizer calculation Thread-Index: AcwrRT1MsuA/uMijRhebCLRNP7pMwwAGUTig Message-ID: <19F8576C6E063C45BE387C64729E739404E307228C@dbde02.ent.ti.com> References: <4DB67614.7030008@gmail.com> <4DF8865F.5010007@gmail.com> In-Reply-To: <4DF8865F.5010007@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 30 > -----Original Message----- > From: Vladimir Pantelic [mailto:vladoman@gmail.com] > Sent: Wednesday, June 15, 2011 3:46 PM > To: Kernel development list > Cc: linux-omap@vger.kernel.org; Hiremath, Vaibhav > Subject: Re: [PATCH] omap v4l2: fix wrong resizer calculation > > ping [Hiremath, Vaibhav] Sorry for delayed response, somehow I completely missed this patch. Thanks for finding this bug, the patch looks ok to me. Only one suggestion I have is to update the description of patch commit, request you to change like following - ---- The omap_vout_new_crop() function has possible bug, uses uninitialized variable "crop.width/height" which is actually output of the function. Instead we should be using "try_crop.width/height" to calculate the resizer value. ---- Rest everything looks ok, while submitting patch again you can add my ack; I will queue to my Arago repo. Also I have tested this patch on OMAP3EVM platform, and it seems to be working fine. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/