Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 30 Jul 2002 17:41:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 30 Jul 2002 17:41:11 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:33036 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id ; Tue, 30 Jul 2002 17:40:33 -0400 Message-ID: <3D47089C.6030504@mandrakesoft.com> Date: Tue, 30 Jul 2002 17:43:56 -0400 From: Jeff Garzik Organization: MandrakeSoft User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020510 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Morton CC: Marcelo Tosatti , lkml , Andrea Arcangeli Subject: Re: [patch] disable READA References: <3D47043E.413E9803@zip.com.au> X-Enigmail-Version: 0.65.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 28 Andrew Morton wrote: > There's a bug in bread() which can cause it to misinterpret a > failed READA request as an IO error on SMP. > --- 2.4.19-rc3/drivers/block/ll_rw_blk.c~no-readahead Tue Jul 30 14:18:17 2002 > +++ 2.4.19-rc3-akpm/drivers/block/ll_rw_blk.c Tue Jul 30 14:19:52 2002 > @@ -841,7 +841,9 @@ static int __make_request(request_queue_ > rw_ahead = 0; /* normal case; gets changed below for READA */ > switch (rw) { > case READA: > +#if 0 /* bread() misinterprets failed READA attempts as IO errors on SMP */ > rw_ahead = 1; > +#endif If the problem is only on SMP, then that should be #ifndef CONFIG_SMP... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/