Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753273Ab1FOSmq (ORCPT ); Wed, 15 Jun 2011 14:42:46 -0400 Received: from mga02.intel.com ([134.134.136.20]:42295 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013Ab1FOSmn (ORCPT ); Wed, 15 Jun 2011 14:42:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,370,1304319600"; d="scan'208";a="13942404" Subject: Re: REGRESSION: Performance regressions from switching anon_vma->lock to mutex From: Tim Chen To: Peter Zijlstra Cc: Andi Kleen , Shaohua Li , Andrew Morton , Linus Torvalds , Hugh Dickins , KOSAKI Motohiro , Benjamin Herrenschmidt , David Miller , Martin Schwidefsky , Russell King , Paul Mundt , Jeff Dike , Richard Weinberger , "Luck, Tony" , KAMEZAWA Hiroyuki , Mel Gorman , Nick Piggin , Namhyung Kim , "Shi, Alex" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "Rafael J. Wysocki" In-Reply-To: <1308156337.2171.23.camel@laptop> References: <1308097798.17300.142.camel@schen9-DESK> <1308101214.15392.151.camel@sli10-conroe> <1308138750.15315.62.camel@twins> <20110615161827.GA11769@tassilo.jf.intel.com> <1308156337.2171.23.camel@laptop> Content-Type: text/plain; charset="UTF-8" Date: Wed, 15 Jun 2011 11:43:18 -0700 Message-ID: <1308163398.17300.147.camel@schen9-DESK> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 29 On Wed, 2011-06-15 at 18:45 +0200, Peter Zijlstra wrote: > On Wed, 2011-06-15 at 09:18 -0700, Andi Kleen wrote: > > > And in general it looks like blind conversion from spinlock to mutex > > is a bad idea right now. > > For 4 socket machines, maybe. On 2 sockets I cannot reproduce anything. > > I wonder if its the fairness thing, the mutex spinners aren't fifo fair > like the ticket locks are. It could be significant with larger socket > count since their cacheline arbitration is more sucky. > > > Peter, Wonder if you can provide the profile on your run so I can compare with what I got on 4 sockets? Thanks. Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/