Date: Wed, 15 Jun 2011 20:46:25 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Greg Kurz <gkurz@fr.ibm.com>
Cc: akpm@linux-foundation.org, containers@lists.osdl.org,
        linux-kernel@vger.kernel.org, serge@hallyn.com, daniel.lezcano@free.fr,
        ebiederm@xmission.com, xemul@openvz.org
Subject: Re: [PATCH] Introduce ActivePid: in /proc/self/status (v2, was
	Vpid:)
Message-ID: <20110615184625.GA15573@redhat.com>
References: <20110615145527.4016.70157.stgit@bahia.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110615145527.4016.70157.stgit@bahia.local>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 866
Lines: 27

On 06/15, Greg Kurz wrote:
>
> @@ -176,6 +177,17 @@ static inline void task_state(struct seq_file *m, struct pid_namespace *ns,
>  		if (tracer)
>  			tpid = task_pid_nr_ns(tracer, ns);
>  	}
> +	actpid = 0;
> +	sighand = rcu_dereference(p->sighand);
> +	if (sighand) {
> +		struct pid_namespace *pid_ns;
> +		unsigned long flags;
> +		spin_lock_irqsave(&sighand->siglock, flags);

Well. This is not exactly right. We have lock_task_sighand() for this.

But. Why do you need ->siglock? Why rcu_read_lock() is not enough?

Hmm. You don't even need pid_ns afaics, you could simply look at
pid->numbers[pid->level].

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/