Message-ID: <4DF90801.4090904@mit.edu>
Date: Wed, 15 Jun 2011 15:29:05 -0400
From: Andy Lutomirski <luto@MIT.EDU>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10
MIME-Version: 1.0
Newsgroups: gmane.linux.kernel
To: Olivier Galibert <galibert@pobox.com>
CC: Linus Torvalds <torvalds@linux-foundation.org>,
        Denys Vlasenko <vda.linux@googlemail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 3.0-rc3
References: <BANLkTinCfV4owNBhJ+F-yfF3V+wg1o=PLA@mail.gmail.com> <BANLkTim_bHKdZnykedzW4re6GMCg+1Ed2g@mail.gmail.com> <BANLkTi=MvvdTZAHG3N=HHTQd9v6uPNHfzw@mail.gmail.com> <20110615071555.GA26721@dspnet.fr>
In-Reply-To: <20110615071555.GA26721@dspnet.fr>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1335
Lines: 36

On 06/15/2011 03:15 AM, Olivier Galibert wrote:
> On Tue, Jun 14, 2011 at 10:59:41AM -0700, Linus Torvalds wrote:
>> On Tue, Jun 14, 2011 at 5:15 AM, Denys Vlasenko
>> <vda.linux@googlemail.com>  wrote:
>>>
>>> I've got a patch for my project to fix parsing of kernel version which
>>> has only two numbers. Basically,
>>>
>>> - scanf(ver, "%u.%u.%u",&a,&b,&c)
>>> + sscanf(ver, "%u.%u",&a,&b)
>>
>> Please just fix it.
>>
>> The projects that care about kernel version are buggy in so many ways
>> that it's not funny.
>
> His problem is recognizing "kernel version" vs. "filename" as a
> parameter.
>    depmod [ -e ]  [ -FSystem.map ]  [ -n ]  [ -v ]  [ version ]  [ filename... ]
>
> Oh course, that's a stupid interface, but probably a hard one to
> change.

Well, the man page says that the version parameter is used to find 
/lib/modules/version.  So why not check if /lib/modules/version exists 
and, if not, try the filename?

/me is still annoyed that some expensive commercial software over here 
won't start if you have funny characters like '+' in your kernel version.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/