Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751796Ab1FPEqA (ORCPT ); Thu, 16 Jun 2011 00:46:00 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:50629 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962Ab1FPEp5 (ORCPT ); Thu, 16 Jun 2011 00:45:57 -0400 MIME-Version: 1.0 In-Reply-To: <20110615213549.9b399976.randy.dunlap@oracle.com> References: <201106160359.p5G3x3j4020081@hera.kernel.org> <20110615213549.9b399976.randy.dunlap@oracle.com> From: Linus Torvalds Date: Wed, 15 Jun 2011 21:45:00 -0700 Message-ID: Subject: Re: fs/exec.c: use BUILD_BUG_ON for VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP To: Randy Dunlap Cc: Linux Kernel Mailing List , akpm , Michal Hocko Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 28 On Wed, Jun 15, 2011 at 9:35 PM, Randy Dunlap wrote: > > fwiw, I just reported that this causes a build error in UML on x86_64 > in mmotm-2011-06-15: Gaah. That sounds really familiar. Have we done this same mistake once before already, or is it just deja-vu for some other reason. On x86-64 UML, we have #define VM_STACK_DEFAULT_FLAGS vm_stack_flags so VM_STACK_FLAGS ends up not being a constant, even though it really looks like one. UML is _really_ confused in this area, btw. It seems to re-define that thing if TIF_IA32 is defined. That's some crazy stuff. Doesn't the compiler warn about it? I guess I should just revert that commit, though. Even if it does seem to be the case that UML is just being crazy. Andrew? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/