Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756915Ab1FPJgi (ORCPT ); Thu, 16 Jun 2011 05:36:38 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:56340 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756441Ab1FPJgg (ORCPT ); Thu, 16 Jun 2011 05:36:36 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Date: Thu, 16 Jun 2011 11:36:32 +0200 From: Richard Weinberger To: Andrew Morton Cc: Linus Torvalds , Randy Dunlap , Linux Kernel Mailing List , Michal Hocko Subject: Re: fs/exec.c: use BUILD_BUG_ON for VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP In-Reply-To: <20110615215207.ba7a0386.akpm@linux-foundation.org> References: <201106160359.p5G3x3j4020081@hera.kernel.org> <20110615213549.9b399976.randy.dunlap@oracle.com> <20110615215207.ba7a0386.akpm@linux-foundation.org> Message-ID: User-Agent: RoundCube Webmail Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 43 On Wed, 15 Jun 2011 21:52:07 -0700, Andrew Morton wrote: > On Wed, 15 Jun 2011 21:45:00 -0700 Linus Torvalds > wrote: > >> On Wed, Jun 15, 2011 at 9:35 PM, Randy Dunlap wrote: >> > >> > fwiw, I just reported that this causes a build error in UML on x86_64 >> > in mmotm-2011-06-15: >> >> Gaah. That sounds really familiar. Have we done this same mistake once >> before already, or is it just deja-vu for some other reason. >> >> On x86-64 UML, we have >> >> #define VM_STACK_DEFAULT_FLAGS vm_stack_flags >> >> so VM_STACK_FLAGS ends up not being a constant, even though it really >> looks like one. >> >> UML is _really_ confused in this area, btw. It seems to re-define that >> thing if TIF_IA32 is defined. That's some crazy stuff. Doesn't the >> compiler warn about it? >> >> I guess I should just revert that commit, though. Even if it does seem >> to be the case that UML is just being crazy. Andrew? >> > > Sure, it was just a tiny optimization. > > We can bring it back if Richard feels like decrazyifying UML ;) > I'll look at this. BTW: 64bit UML is really crazy. :P Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/