Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932178Ab1FPOlv (ORCPT ); Thu, 16 Jun 2011 10:41:51 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:49626 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932136Ab1FPOlu (ORCPT ); Thu, 16 Jun 2011 10:41:50 -0400 Date: Thu, 16 Jun 2011 08:41:46 -0600 From: Grant Likely To: Ambresh K Cc: linux kernel , Philippe Mazet , Kevin Hilman , Colin Cross , linux omap Subject: Re: [PATCH] OMAP4: GPIO: Fix missing interrupts during device wakeup due to IOPAD. Message-ID: <20110616144146.GC2806@ponder.secretlab.ca> References: <1308170445-30665-1-git-send-email-ambresh@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1308170445-30665-1-git-send-email-ambresh@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1778 Lines: 47 On Wed, Jun 15, 2011 at 01:40:45PM -0700, Ambresh K wrote: > From: Ambresh K > > If gpio pins from bank[2-5] are marked as wakeup enable and if the wake is > through gpio IO pad wakeup, then that wakeup gpio interrupt is lost. > > In the current implementation, GPIO driver stores the context of DATAIN of > all the gpio in the bank. During GPIO resuming, it checks DATAIN with wakeup > enabled pins of gpio bank. If there is status change, then manually toggle > GPIO_LEVELDETECT to generate pseudo interrupt. > > Reported-by: Philippe Mazet > Tested-by: Philippe Mazet > Signed-off-by: Ambresh K Applied, thanks. g. > --- > drivers/gpio/gpio-omap.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index 6c51191..eaf3d78 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -477,8 +477,9 @@ static inline void set_24xx_gpio_triggering(struct gpio_bank *bank, int gpio, > + OMAP24XX_GPIO_CLEARWKUENA); > } > } > - /* This part needs to be executed always for OMAP34xx */ > - if (cpu_is_omap34xx() || (bank->non_wakeup_gpios & gpio_bit)) { > + /* This part needs to be executed always for OMAP{34xx, 44xx} */ > + if (cpu_is_omap34xx() || cpu_is_omap44xx() || > + (bank->non_wakeup_gpios & gpio_bit)) { > /* > * Log the edge gpio and manually trigger the IRQ > * after resume if the input level changes > -- > 1.7.0.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/