Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757137Ab1FPPUt (ORCPT ); Thu, 16 Jun 2011 11:20:49 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:40340 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757009Ab1FPPUp (ORCPT ); Thu, 16 Jun 2011 11:20:45 -0400 Date: Thu, 16 Jun 2011 11:20:45 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Tatyana Brokhman cc: greg@kroah.com, , , , , Amit Blay , open list Subject: Re: [PATCH/RFC 5/5] usb: Add support for streams alloc/dealloc to devio.c In-Reply-To: <1308231068-24038-6-git-send-email-tlinder@codeaurora.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 40 On Thu, 16 Jun 2011, Tatyana Brokhman wrote: > Allow user space applications such as LIBUSB, to request > streams alloc/dealloc from HCD that implements XHCI. > > Signed-off-by: Amit Blay > Signed-off-by: Tatyana Brokhman ... > diff --git a/include/linux/usbdevice_fs.h b/include/linux/usbdevice_fs.h > index 15591d2..133c216 100644 > --- a/include/linux/usbdevice_fs.h > +++ b/include/linux/usbdevice_fs.h > @@ -108,6 +108,7 @@ struct usbdevfs_urb { > or 0 if none should be sent. */ > void __user *usercontext; > struct usbdevfs_iso_packet_desc iso_frame_desc[0]; > + unsigned int stream_id; > }; > > /* ioctls for talking directly to drivers */ > @@ -165,6 +166,7 @@ struct usbdevfs_urb32 { > compat_uint_t signr; > compat_caddr_t usercontext; /* unused */ > struct usbdevfs_iso_packet_desc iso_frame_desc[0]; > + compat_uint_t stream_id; > }; It would be nice if we could do this, but we can't. We are not allowed to change an established ABI. Every copy of libusb would have to be rebuilt. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/