Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757744Ab1FPTbA (ORCPT ); Thu, 16 Jun 2011 15:31:00 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:41076 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901Ab1FPTa6 convert rfc822-to-8bit (ORCPT ); Thu, 16 Jun 2011 15:30:58 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=C2fjI8VjJmR22sKJwKAYi6Uur14cKa5BV6pIZcWj9eET93VVrEnxeXWiEvgC36Ql8y xxtCPQZPW1y1cqJSgYVnlB24RPXSuRTCC26Grv9Ngby7hjrf9geo1XVMSz2BWpF5D001 2GzlzufjTucfZuly6ipK1ZRSDUD3FNFVjp4lM= MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 16 Jun 2011 21:30:56 +0200 X-Google-Sender-Auth: 1P2Qge3Vx-MlbFZkdIy5hJ9qmPY Message-ID: Subject: Re: m68k: Convert to genirq (WIP) From: Geert Uytterhoeven To: "Linux/m68k" Cc: Thomas Gleixner , Linux Kernel Development Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2259 Lines: 48 On Wed, Jun 15, 2011 at 21:44, Geert Uytterhoeven wrote: > On Sat, Jun 4, 2011 at 19:56, Geert Uytterhoeven wrote: >> On Sat, May 28, 2011 at 20:32, Geert Uytterhoeven wrote: >>> Now sparc32 has beaten me, I pushed out my work in progress of converting m68k >>> to use the generic hardirq framework: >>> >>> git://git.kernel.org:/pub/scm/linux/kernel/git/geert/linux-m68k.git m68k-genirq >>> http://git.kernel.org/?p=linux/kernel/git/geert/linux-m68k.git;a=shortlog;h=refs/heads/m68k-genirq >> >>> Next on my list is Amiga, which will cover autovectored and chained interrupts. >> >> I rebased to 3.0-rc1 and added (not in that order): >>  [10] m68k/irq: Add m68k_setup_irq_controller() >>  [11] m68k/irq: Adding missing "irq" offset in m68k_setup_irq_controller() >>  [12] m68k/irq: Fix auto and user chips and handlers >>  [13] m68k/amiga: Refactor amiints.c >>  [14] m68k/amiga: Convert Amiga to genirq >>  [15] m68k/amiga: Optimize interrupts using chain handlers >> >> It works on Amiga now, too. It can still use some optimizations in the >> irq_{enable,disable,ack,mask,mask_ack,unmask} area, as my BogoMIPS >> rating dropped by ca 2.5% and is now under 16, for a 25 MHz 68040. > > Seems like everything (Atari/ARAnyM and Amiga) still works when using > handle_simple_irq instead of handle_level_irq. > As a bonus, BogoMIPS is above 16 again. With handle_simple_irq(), we no longer need to define irq_{,un}mask() methods in our irq_chips. Hence the "old" m68k platform interrupt code seems to be much closer to genirq than I thought... Does this make sense? Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/