Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756995Ab1FPUaa (ORCPT ); Thu, 16 Jun 2011 16:30:30 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:46708 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754887Ab1FPUa2 (ORCPT ); Thu, 16 Jun 2011 16:30:28 -0400 Date: Thu, 16 Jun 2011 16:30:27 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Alexander Holler cc: Arnd Bergmann , , Rabin Vincent , , , Subject: Re: [PATCH] USB: ehci: use packed,aligned(4) instead of removing the packed attribute In-Reply-To: <4DFA634D.6000907@ahsoftware.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 30 On Thu, 16 Jun 2011, Alexander Holler wrote: > > Hmmm. I won't say that ((packed,aligned(4))) is wrong. But it's not > > clearly necessary either. > > Maybe I should have added a "cosmetic:" in front of the subject of the > patch. ;) > > Using packed doesn't seem to be necessary (at least not with those > versions of gcc I'm using here), I've tried both versions (on arm, > without packed and with packed, aligned(4)) and both are working. I've > only posted the patch because I found the usage of packed, aligned(4) > much clearer than without packed. And It might help avoiding such > discussions like this with people like me who aren't that deep involved > in gcc-specific implementation details. ;) > > Anyway, feel free to nack that patch. I don't really care and just > thought I should post it (e.g. as an alternative to removing that packed). There are other structures that need to avoid padding but aren't marked ((packed)), such as ehci_qtd and ehci_qh_hw in drivers/usb/host/ehci.h. I don't see why those in ehci_def.h should get special treatment. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/