Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758075Ab1FQBt3 (ORCPT ); Thu, 16 Jun 2011 21:49:29 -0400 Received: from mail05-md.ns.itscom.net ([175.177.155.115]:33092 "EHLO mail05-md.ns.itscom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757950Ab1FQBt1 (ORCPT ); Thu, 16 Jun 2011 21:49:27 -0400 From: "J. R. Okajima" Subject: Re: [PATCH 0/7] overlay filesystem: request for inclusion To: Erez Zadok Cc: Andrew Morton , Miklos Szeredi , "viro@ZenIV.linux.org.uk Viro" , Linus Torvalds , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "apw@canonical.com" , "nbd@openwrt.org" , "neilb@suse.de" , "hramrach@centrum.cz" , "jordipujolp@gmail.com" , "mszeredi@suse.cz" In-Reply-To: References: <1306932380-10280-1-git-send-email-miklos@szeredi.hu> <4540f7aa16724111bd792a1d577261c2@HUBCAS1.cs.stonybrook.edu> <954F11FF-339B-48E2-8358-A158DE1E53BC@fsl.cs.sunysb.edu> Date: Fri, 17 Jun 2011 10:49:20 +0900 Message-ID: <16748.1308275360@jrobl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1315 Lines: 35 Erez Zadok: > OK. Then I believe you and I are in agreement: > > - Overlayfs has useful features to be merged now; no objections here. > - Other features can be added later on. Yes, that is what I wrote. > If, however, you feel that Overlayfs has some fundamental design flaws = > that prevent important future features from being added easily after a = > merge, then please outline such design flaws. I have made some suggestions and pointed out several issues actually. If my English is enough poor to make you misunderstood, then please point out with quoting. But Erez, don't you remember that you requested me to promise not to submit aufs for inclusion into mainline until unionfs gets accepted and I agreed? Do you really think I am bothering overlayfs? Here is a suggestion about your patch for ovl_show_options(). It is better to call d_path() or something instead of copying and holding the paths, since overlayfs already has mnt and dentry. And with d_path(), show_options will be able to follow even if the upper/lower mount is moved. J. R. Okajima -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/