Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755184Ab1FQDK4 (ORCPT ); Thu, 16 Jun 2011 23:10:56 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:51449 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754836Ab1FQDKy (ORCPT ); Thu, 16 Jun 2011 23:10:54 -0400 Date: Thu, 16 Jun 2011 23:10:18 -0400 (EDT) Message-Id: <20110616.231018.84570655636629416.davem@davemloft.net> To: shemminger@vyatta.com Cc: gthelen@google.com, shemminger@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sky2: avoid using uninitialized variable From: David Miller In-Reply-To: <20110614000230.4166a1ae@s6510.ftrdhcpuser.net> References: <20110613181212.571f8e76@s6510.ftrdhcpuser.net> <20110614000230.4166a1ae@s6510.ftrdhcpuser.net> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Thu, 16 Jun 2011 20:10:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 18 From: Stephen Hemminger Date: Tue, 14 Jun 2011 00:02:30 -0400 > In my experience if phy reads once successfully, it is going > to read every time. If there is a problem it only happens on > the first access (powered off, bad timing, etc). It also happens when the PHY can't get a response for a certain register, for whatever reason, before internal hw timeouts trigger. Please, check all MII accesses. That's what I do in every driver I've written. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/