Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756668Ab1FQG6Q (ORCPT ); Fri, 17 Jun 2011 02:58:16 -0400 Received: from mail1.asahi-net.or.jp ([202.224.39.197]:28789 "EHLO mail1.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755524Ab1FQG6O (ORCPT ); Fri, 17 Jun 2011 02:58:14 -0400 Date: Fri, 17 Jun 2011 15:58:12 +0900 Message-ID: <87tybpndvf.wl%ysato@users.sourceforge.jp> From: Yoshinori Sato To: Mike Frysinger Cc: linux-kernel@vger.kernel.org, uClinux development list Subject: Re: [PATCH] binfmt_flat: missing argv table In-Reply-To: References: <874o3rimbn.wl%ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/23.3 (i486-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 958 Lines: 28 At Wed, 15 Jun 2011 11:52:33 -0400, Mike Frysinger wrote: > > On Wed, Jun 15, 2011 at 03:30, Yoshinori Sato wrote: > > "put_user" is multiple times evalute on argument > > (in asm-generic/uaccess.h). > > So this code building argv table include gabage. > > NAK. asm-generic/uaccess.h is broken. i posted some fixes some time > ago to lkml for the header to clean it all up, but it had some minor > build warnings that needed to be addressed. > > if you want to actually fix this issue, please start with my patch and > get the issues around it resolved: > asm-generic: uaccess: do not expand args multiple times > -mike OK. I found it. and trying cleanup. -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/