Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759545Ab1FQRWm (ORCPT ); Fri, 17 Jun 2011 13:22:42 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:40567 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759507Ab1FQRWj (ORCPT ); Fri, 17 Jun 2011 13:22:39 -0400 From: Andreas Schwab To: Geert Uytterhoeven Cc: Michael Schmitz , Thomas Gleixner , Linux Kernel Development , "Linux\/m68k" Subject: Re: m68k: Convert to genirq (WIP) References: X-Yow: --- I have seen the FUN --- Date: Fri, 17 Jun 2011 19:22:35 +0200 In-Reply-To: (Geert Uytterhoeven's message of "Thu, 16 Jun 2011 21:45:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 26 Geert Uytterhoeven writes: > This is the WARN_ONCE(!irqs_disabled()) check. > > static inline bool arch_irqs_disabled_flags(unsigned long flags) > { > return (flags & ~ALLOWINT) != 0; That should be return (flags & 0x700) == 0x700; It doesn't make sense to use ALLOWINT here, since arch_local_irq_disable doesn't use it either. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/