Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753147Ab1FRVwt (ORCPT ); Sat, 18 Jun 2011 17:52:49 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:56655 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752854Ab1FRVwr (ORCPT ); Sat, 18 Jun 2011 17:52:47 -0400 Date: Sat, 18 Jun 2011 14:52:54 -0700 From: Andrew Morton To: Hugh Dickins Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/12] mm: let swap use exceptional entries Message-Id: <20110618145254.1b333344.akpm@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1242 Lines: 32 On Tue, 14 Jun 2011 03:43:47 -0700 (PDT) Hugh Dickins wrote: > --- linux.orig/mm/filemap.c 2011-06-13 13:26:44.430284135 -0700 > +++ linux/mm/filemap.c 2011-06-13 13:27:34.526532556 -0700 > @@ -717,9 +717,12 @@ repeat: > page = radix_tree_deref_slot(pagep); > if (unlikely(!page)) > goto out; > - if (radix_tree_deref_retry(page)) > + if (radix_tree_exception(page)) { > + if (radix_tree_exceptional_entry(page)) > + goto out; > + /* radix_tree_deref_retry(page) */ > goto repeat; > - > + } > if (!page_cache_get_speculative(page)) > goto repeat; All the crap^Wnice changes made to filemap.c really need some comments, please. Particularly when they're keyed off the bland-sounding "radix_tree_exception()". Apparently they have something to do with swap, but how is the poor reader to know this? Also, commenting out a function call might be meaningful information for Hugh-right-now, but for other people later on, they're just a big WTF. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/