Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753297Ab1FSKBR (ORCPT ); Sun, 19 Jun 2011 06:01:17 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:57037 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752369Ab1FSKBP (ORCPT ); Sun, 19 Jun 2011 06:01:15 -0400 Date: Sun, 19 Jun 2011 11:03:28 +0100 From: Alan Cox To: Arnd Bergmann Cc: Wim Van Sebroeck , LKML , Linux Watchdog Mailing List Subject: Re: [PATCH 7/10 v2] Generic Watchdog Timer Driver Message-ID: <20110619110328.39c0f5e1@lxorguk.ukuu.org.uk> In-Reply-To: <201106182107.45682.arnd@arndb.de> References: <20110618172537.GH3441@infomag.iguana.be> <201106182107.45682.arnd@arndb.de> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 21 > > /* Register the watchdog timer device */ > > res = watchdog_register_device(&wdt_dev); > > Why is this a feature of the individual drivers and not of the core? It's a hardware dependant feature - some watchdogs cannot be stopped once initialized. > Maybe it can be in both, so existing drivers don't need to change the user > interface, but new drivers don't have to provide the option individually > when you can simply set it for the base module. Then you'd need an additional interface to specify which watchdog as soon as we support multiple watchdogs. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/