Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753973Ab1FSNhB (ORCPT ); Sun, 19 Jun 2011 09:37:01 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:64511 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753709Ab1FSNg7 convert rfc822-to-8bit (ORCPT ); Sun, 19 Jun 2011 09:36:59 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=gVMofGovkxk/2kgjt8YjGaZa0+W/pn1GFD/RuYl8LQh7+2bdCmuuGgXkIVAw9LUAad d3QoYk5oC5K0eG6yLoDO/kfd1dg6Q3PMRdhvh8Sx+f2YIxD1Gj6EsptweXFqwzkYUNUb BqO9UIAEnPVVlvA7UJVxKLNd/7IWDyaKAlZpQ= MIME-Version: 1.0 In-Reply-To: References: Date: Sun, 19 Jun 2011 15:36:58 +0200 X-Google-Sender-Auth: JVMQvxsApZrKQiKffBDzSyL3W8Y Message-ID: Subject: Re: m68k: Convert to genirq (WIP) From: Geert Uytterhoeven To: Andreas Schwab Cc: Michael Schmitz , Thomas Gleixner , Linux Kernel Development , "Linux/m68k" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1204 Lines: 28 On Sun, Jun 19, 2011 at 13:19, Andreas Schwab wrote: > Geert Uytterhoeven writes: > >> BUG_ON(!irqs_disabled()) triggers as flags is 0x2619 there. > > Which is correct, since arch_local_irq_disable would set it to 2719. > You need to find out why arch_local_irq_disable wasn't called. I don't think we ever explicitly disable interrupts in interrupt handlers. The CPU disables all interupts of the same or lower level anyway. As all Atari interrupts (except for hblank and vblank) run at level 6, this is why flags & 0x700 == 0x600 above. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/