Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754091Ab1FSN7C (ORCPT ); Sun, 19 Jun 2011 09:59:02 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:39186 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754027Ab1FSN7A (ORCPT ); Sun, 19 Jun 2011 09:59:00 -0400 From: Andreas Schwab To: Geert Uytterhoeven Cc: Michael Schmitz , Thomas Gleixner , Linux Kernel Development , "Linux\/m68k" Subject: Re: m68k: Convert to genirq (WIP) References: X-Yow: YUGGA-HUGGA-BUGGA-TUGGA!! HEY-HEY!! A TRAIN STATION!! No, a POST OFFICE!! An OCEAN LINER!! No, I think it's a CAFETERIA!!! Date: Sun, 19 Jun 2011 15:58:57 +0200 In-Reply-To: (Geert Uytterhoeven's message of "Sun, 19 Jun 2011 15:36:58 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 25 Geert Uytterhoeven writes: > On Sun, Jun 19, 2011 at 13:19, Andreas Schwab wrote: >> Geert Uytterhoeven writes: >> >>> BUG_ON(!irqs_disabled()) triggers as flags is 0x2619 there. >> >> Which is correct, since arch_local_irq_disable would set it to 2719. >> You need to find out why arch_local_irq_disable wasn't called. > > I don't think we ever explicitly disable interrupts in interrupt handlers. Then the BUG_ON is wrong. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/