Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753304Ab1FTG7S (ORCPT ); Mon, 20 Jun 2011 02:59:18 -0400 Received: from smtp-out.google.com ([216.239.44.51]:20325 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576Ab1FTG7R convert rfc822-to-8bit (ORCPT ); Mon, 20 Jun 2011 02:59:17 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=RAV00jqgMSgMMvjtmvjP5OeW6cshIi8dYH2iFtJUirPEKXp8DQaZX+ioWO5y0psdN1 b9eda/mwIKa2ozwB/ZcA== MIME-Version: 1.0 In-Reply-To: <20110620130227.6202e8f6.kamezawa.hiroyu@jp.fujitsu.com> References: <20110616124730.d6960b8b.kamezawa.hiroyu@jp.fujitsu.com> <20110616125314.4f78b1e0.kamezawa.hiroyu@jp.fujitsu.com> <20110620084123.c63d3e12.kamezawa.hiroyu@jp.fujitsu.com> <20110620130227.6202e8f6.kamezawa.hiroyu@jp.fujitsu.com> Date: Sun, 19 Jun 2011 23:59:13 -0700 Message-ID: Subject: Re: [PATCH 3/7] memcg: add memory.scan_stat From: Ying Han To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "nishimura@mxp.nes.nec.co.jp" , "bsingharora@gmail.com" , Michal Hocko , "hannes@cmpxchg.org" , Andrew Bresticker Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3324 Lines: 93 On Sunday, June 19, 2011, KAMEZAWA Hiroyuki wrote: > On Mon, 20 Jun 2011 08:41:23 +0900 > KAMEZAWA Hiroyuki wrote: > >> On Fri, 17 Jun 2011 15:04:18 -0700 >> Ying Han wrote: >> >> > On Wed, Jun 15, 2011 at 8:53 PM, KAMEZAWA Hiroyuki >> > wrote: >> > > From e08990dd9ada13cf236bec1ef44b207436434b8e Mon Sep 17 00:00:00 2001 >> > > From: KAMEZAWA Hiroyuki >> > > Date: Wed, 15 Jun 2011 14:11:01 +0900 >> > > Subject: [PATCH 3/7] memcg: add memory.scan_stat >> > > >> > > commit log of commit 0ae5e89 " memcg: count the soft_limit reclaim in..." >> > > says it adds scanning stats to memory.stat file. But it doesn't because >> > > we considered we needed to make a concensus for such new APIs. >> > > >> > > This patch is a trial to add memory.scan_stat. This shows >> > > ?- the number of scanned pages >> > > ?- the number of recleimed pages >> > > ?- the number of elaplsed time (including sleep/pause time) >> > > ?for both of direct/soft reclaim and shrinking caused by changing limit >> > > ?or force_empty. >> > > >> > > The biggest difference with oringinal Ying's one is that this file >> > > can be reset by some write, as >> > > >> > > ?# echo 0 ...../memory.scan_stat >> > > >> > > [kamezawa@bluextal ~]$ cat /cgroup/memory/A/memory.scan_stat >> > > scanned_pages_by_limit 358470 >> > > freed_pages_by_limit 180795 >> > > elapsed_ns_by_limit 21629927 >> > > scanned_pages_by_system 0 >> > > freed_pages_by_system 0 >> > > elapsed_ns_by_system 0 >> > > scanned_pages_by_shrink 76646 >> > > freed_pages_by_shrink 38355 >> > > elappsed_ns_by_shrink 31990670 >> > > total_scanned_pages_by_limit 358470 >> > > total_freed_pages_by_limit 180795 >> > > total_elapsed_ns_by_hierarchical 216299275 >> > > total_scanned_pages_by_system 0 >> > > total_freed_pages_by_system 0 >> > > total_elapsed_ns_by_system 0 >> > > total_scanned_pages_by_shrink 76646 >> > > total_freed_pages_by_shrink 38355 >> > > total_elapsed_ns_by_shrink 31990670 >> > > >> > > total_xxxx is for hierarchy management. >> > > >> > > This will be useful for further memcg developments and need to be >> > > developped before we do some complicated rework on LRU/softlimit >> > > management. >> > >> > Agreed. Actually we are also looking into adding a per-memcg API for >> > adding visibility of >> > page reclaim path. It would be helpful for us to settle w/ the API first. >> > >> > I am not a fan of names, but how about >> > "/dev/cgroup/memory/memory.reclaim_stat" ? >> > >> >> Hm, ok, I have no favorite. >> >> > > If I rename, I'll just rename file name as "reclaim_stat" but doesn't > rename internal structures because there is already "struct reclaim_stat". > > Hm, to be honest, I don't like the name "reclaim_stat". > (Because in most case, the pages are not freed for reclaim, but for > ?hitting limit.) > > memory.vmscan_info ? No objection on the name. I will look into the other part of the patch Thanks --ying > > Thanks, > -Kame > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/