Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753338Ab1FTHVy (ORCPT ); Mon, 20 Jun 2011 03:21:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29001 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753166Ab1FTHVv (ORCPT ); Mon, 20 Jun 2011 03:21:51 -0400 Date: Mon, 20 Jun 2011 10:21:28 +0300 From: Gleb Natapov To: Avi Kivity Cc: Glauber Costa , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Rik van Riel , Jeremy Fitzhardinge , Peter Zijlstra , Anthony Liguori , Eric B Munson Subject: Re: [PATCH 3/7] KVM-HV: KVM Steal time implementation Message-ID: <20110620072128.GW491@redhat.com> References: <1308007897-17013-1-git-send-email-glommer@redhat.com> <1308007897-17013-4-git-send-email-glommer@redhat.com> <20110614074500.GM491@redhat.com> <4DF8226B.20408@redhat.com> <20110615090951.GQ491@redhat.com> <4DFDED2E.6030009@redhat.com> <20110619125956.GV491@redhat.com> <4DFDF35E.8030504@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DFDF35E.8030504@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1497 Lines: 35 On Sun, Jun 19, 2011 at 04:02:22PM +0300, Avi Kivity wrote: > On 06/19/2011 03:59 PM, Gleb Natapov wrote: > >On Sun, Jun 19, 2011 at 03:35:58PM +0300, Avi Kivity wrote: > >> On 06/15/2011 12:09 PM, Gleb Natapov wrote: > >> >> > >> >> Actually, I'd expect most read/writes to benefit from caching, no? > >> >> So why don't we just rename kvm_write_guest_cached() to > >> >> kvm_write_guest(), and the few places - if any - that need to force > >> >> transversing of the gfn mappings, get renamed to > >> >> kvm_write_guest_uncached ? > >> >> > >> >Good idea. I do not see any places where kvm_write_guest_uncached is > >> >needed from a brief look. Avi? > >> > > >> > >> kvm_write_guest_cached() needs something to supply the cache, and > >> needs recurring writes to the same location. Neither of these are > >> common (for example, instruction emulation doesn't have either). > >> > >Correct. Missed that. So what about changing steal time to use > >kvm_write_guest_cached()? > > Makes sense, definitely. Want to post read_guest_cached() as well? > Glauber can you write read_guest_cached() as part of your series (should be trivial), or do you want me to do it? I do not have a code to test it with though :) -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/