Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752980Ab1FTKsI (ORCPT ); Mon, 20 Jun 2011 06:48:08 -0400 Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]:59898 "EHLO na3sys009aog114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752666Ab1FTKsF (ORCPT ); Mon, 20 Jun 2011 06:48:05 -0400 Message-ID: <4DFF255E.5030308@ti.com> Date: Mon, 20 Jun 2011 16:17:58 +0530 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: Russell King - ARM Linux CC: Peter Zijlstra , Thomas Gleixner , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH] ARM: smp: Fix the CPU hotplug race with scheduler. References: <1308561839-18407-1-git-send-email-santosh.shilimkar@ti.com> <20110620095053.GA2082@n2100.arm.linux.org.uk> <20110620101438.GD2082@n2100.arm.linux.org.uk> <4DFF20B3.7010209@ti.com> <20110620104415.GF2082@n2100.arm.linux.org.uk> In-Reply-To: <20110620104415.GF2082@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2886 Lines: 64 On 6/20/2011 4:14 PM, Russell King - ARM Linux wrote: > On Mon, Jun 20, 2011 at 03:58:03PM +0530, Santosh Shilimkar wrote: >> No it doesn't work. I still get the crash. The important point >> here is not to enable interrupts before CPU is marked >> as online and active. > > What is the crash (in full please)? > > Do we know what interrupt is causing it? Yes. It's because of interrupt and the CPU active-online race. Here is the chash log.. [ 21.025451] CPU1: Booted secondary processor [ 21.025451] CPU1: Unknown IPI message 0x1 [ 21.029113] Switched to NOHz mode on CPU #1 [ 21.029174] BUG: spinlock lockup on CPU#1, swapper/0, c06220c4 [ 21.029235] [] (unwind_backtrace+0x0/0xf4) from [] (do_raw_spin_lock+0xd0/0x164) [ 21.029266] [] (do_raw_spin_lock+0xd0/0x164) from [] (tick_do_update_jiffies64+0x3c/0x118) [ 21.029296] [] (tick_do_update_jiffies64+0x3c/0x118) from [] (tick_check_idle+0xb0/0x110) [ 21.029327] [] (tick_check_idle+0xb0/0x110) from [] (irq_enter+0x68/0x70) [ 21.029327] [] (irq_enter+0x68/0x70) from [] (ipi_timer+0x24/0x40) [ 21.029357] [] (ipi_timer+0x24/0x40) from [] (do_local_timer+0x54/0x70) [ 21.029388] [] (do_local_timer+0x54/0x70) from [] (__irq_svc+0x3c/0x120) [ 21.029388] Exception stack(0xef87bf78 to 0xef87bfc0) [ 21.029388] bf60: 00000000 00026ec0 [ 21.029418] bf80: c0622080 ffff7483 c0622080 ffff7483 ef87a000 00000000 c0622080 411fc092 [ 21.029418] bfa0: c063a4f0 00000000 00000001 ef87bfc0 c0482e08 c0482b0c 60000113 ffffffff [ 21.029449] [] (__irq_svc+0x3c/0x120) from [] (calibrate_delay+0x8c/0x1d4) [ 21.029479] [] (calibrate_delay+0x8c/0x1d4) from [] (secondary_start_kernel+0x110/0x1ac) [ 21.029510] [] (secondary_start_kernel+0x110/0x1ac) from [] (platform_cpu_die+0x34/0x54) [ 22.021362] CPU1: failed to come online [ 23.997955] CPU1: failed to come online [ 25.000122] BUG: spinlock lockup on CPU#0, kthreadd/663, efa27e64 [ 25.006408] [] (unwind_backtrace+0x0/0xf4) from [] (do_raw_spin_lock+0xd0/0x164) [ 25.015808] [] (do_raw_spin_lock+0xd0/0x164) from [] (_raw_spin_lock_irqsave+0x4c/0x58) [ 25.025848] [] (_raw_spin_lock_irqsave+0x4c/0x58) from [] (complete+0x1c/0x5c) [ 25.035095] [] (complete+0x1c/0x5c) from [] (kthread+0x68/0x90) [ 25.042968] [] (kthread+0x68/0x90) from [] (kernel_thread_exit+0x0/0x8) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/