Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608Ab1FTLRJ (ORCPT ); Mon, 20 Jun 2011 07:17:09 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:41361 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139Ab1FTLRH (ORCPT ); Mon, 20 Jun 2011 07:17:07 -0400 Date: Mon, 20 Jun 2011 12:16:29 +0100 From: Russell King - ARM Linux To: Jesper Juhl Cc: Sergei Shtylyov , linux-arm-kernel@lists.infradead.org, trivial@kernel.org, linux-kernel@vger.kernel.org, Vasily Khoruzhick , Ben Dooks , Arnaud Patard Subject: Re: [PATCH][Trivial] S3C2410 bluetooth: Remove duplicate linux/leds.h include Message-ID: <20110620111629.GC26089@n2100.arm.linux.org.uk> References: <4DFF1AA5.80508@ru.mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 999 Lines: 27 On Mon, Jun 20, 2011 at 12:34:37PM +0200, Jesper Juhl wrote: > On Mon, 20 Jun 2011, Sergei Shtylyov wrote: > > > Hello. > > > > On 20-06-2011 12:40, Jesper Juhl wrote: > > > > > Remove the duplicate inclusion of linux/leds.h from > > > arch/arm/mach-s3c2410/h1940-bluetooth.c that was added by commit 50e2d10d. > > > > Pelase also specify that commit's summary in parens. > > > > Anyone can just do a "git show 50e2d10d" to read it. But sure, here's a > new patch description: Anyone with git can. Those without git can't (eg, because they're using some other tool for source management.) This is why Linus requires commit IDs to be followed by their summary. Please ensure that you always include the summary along with the git commit id. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/