Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753061Ab1FTQmE (ORCPT ); Mon, 20 Jun 2011 12:42:04 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:42282 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985Ab1FTQmA convert rfc822-to-8bit (ORCPT ); Mon, 20 Jun 2011 12:42:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=X2N5JJwv2FM0k+soa1KrRbdD71Vi18bC3fS+69vCnqBSUm3yQMFXBv/mE4V6VMuYY/ L3AHjIShUWLFzdm+fSmWDe2itHbRWhRqC/ZT4roYy9wzESwLcxvZLiaSHDgEADBvh20Z NCQ3rduptXcnf9k1YUAvUW+NMZHMkOVqWRU9U= MIME-Version: 1.0 In-Reply-To: <20110620160650.GA26623@legolas.emea.dhcp.ti.com> References: <20110620151522.GN14262@legolas.emea.dhcp.ti.com> <20110620153645.GQ14262@legolas.emea.dhcp.ti.com> <20110620160650.GA26623@legolas.emea.dhcp.ti.com> Date: Mon, 20 Jun 2011 18:41:59 +0200 Message-ID: Subject: Re: [PATCH] s3c2410_udc: fix custom UDC command handling From: Skacore Systems To: balbi@ti.com Cc: Alan Stern , Viliam Mateicka , Ben Dooks , Kukjin Kim , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2480 Lines: 64 Yeah I think that one line break and tabs are sabotaging your work. So stop being an 8====O - hole. No wonder if you are paid by TI that one line patch into the upstream takes you so long to comprehend. Vilo On Mon, Jun 20, 2011 at 6:06 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jun 20, 2011 at 05:57:31PM +0200, Skacore Systems wrote: >> Oh and I've finally cloned the mainline git. So here it's the last >> try. I hope the TI people will not sabotage the Samsung's drivers any >> way longer !!! > > Now you're just making an ass of yourself. > > what do you think you will get making such kind of statements ? I just > happen to be hired by TI, there's no such thing as TI trying to sabotage > Samsung's drivers. > > I'll fix this one out myself just to make you stop bothering me, but > don't expect me to put your patches in my priority list. If you really > think TI is sabotaging samsung's drivers, look at the big re-factor we > are doing on the entire Gadget framework, involving not only Samsung's > drivers but all the others. > > Even though you cloned the tree you still make a mistake which will > prevent me from applying the patch without manually editting it. > > On top of that, you decided not to follow our netiquette or our patch > formatting rules just because you think it's "nonsense". If you really > think that, why do you even bother sending the patch to this mailing > list ? > >> diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c >> index 100f263..b6e1ca5 100644 >> --- a/drivers/usb/gadget/s3c2410_udc.c >> +++ b/drivers/usb/gadget/s3c2410_udc.c >> @@ -1567,7 +1567,7 @@ static void s3c2410_udc_command(enum >> s3c2410_udc_cmd_e cmd) > > there shouldn't be this line break here. > >> ? ? ? ? ? ? ? ? return; >> >> ? ? ? ? if (udc_info->udc_command) { >> - ? ? ? ? ? ? ? udc_info->udc_command(S3C2410_UDC_P_DISABLE); >> + ? ? ? ? ? ? ? udc_info->udc_command(cmd); >> ? ? ? ? } else if (gpio_is_valid(udc_info->pullup_pin)) { >> ? ? ? ? ? ? ? ? int value; > > tabs where converted into spaces too. > > Next time, instead of been such an ass, spend some time learning the > process we use to do development. You'll see things will go smoother. > > -- > balbi > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/