Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755354Ab1FTSqd (ORCPT ); Mon, 20 Jun 2011 14:46:33 -0400 Received: from h1446028.stratoserver.net ([85.214.92.142]:34715 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522Ab1FTSqb (ORCPT ); Mon, 20 Jun 2011 14:46:31 -0400 Message-ID: <4DFF9568.8030704@ahsoftware.de> Date: Mon, 20 Jun 2011 20:46:00 +0200 From: Alexander Holler User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: Alan Stern CC: Nicolas Pitre , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, gregkh@suse.de, lkml , Rabin Vincent Subject: Re: [PATCH] USB: ehci: use packed,aligned(4) instead of removing the packed attribute References: In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 27 Am 20.06.2011 20:39, schrieb Alan Stern: > On Mon, 20 Jun 2011, Alexander Holler wrote: > >> I see it that way: packed is needed to be sure that at least for struct >> ehci_regs there are no padding bytes inbetween the members. > > But is it _really_ needed? > >> It might >> work without, but that depends on the compiler (-version, architecture, >> whatever). > > Have there _ever_ been _any_ combinations of compiler, version, > architecture, whatever, that had unwanted padding bytes in this > structure? I don't know. But if there would be no doubts, this discussion would not happen and I assume there never would have been an attribute packed there. Regards, Alexander -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/