Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756182Ab1FTXlp (ORCPT ); Mon, 20 Jun 2011 19:41:45 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:42643 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751439Ab1FTXln (ORCPT ); Mon, 20 Jun 2011 19:41:43 -0400 Date: Tue, 21 Jun 2011 00:41:40 +0100 From: Mark Brown To: Lars-Peter Clausen Cc: linux-kernel@vger.kernel.org, Dimitris Papastamos , Liam Girdwood , Samuel Oritz , Graeme Gregory Subject: Re: [PATCH 2/8] regmap: Add I2C bus support Message-ID: <20110620234140.GB1905@opensource.wolfsonmicro.com> References: <20110620124608.GB31140@opensource.wolfsonmicro.com> <1308574489-31322-1-git-send-email-broonie@opensource.wolfsonmicro.com> <1308574489-31322-2-git-send-email-broonie@opensource.wolfsonmicro.com> <4DFFD64F.8040902@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DFFD64F.8040902@metafoo.de> X-Cookie: You are magnetic in your bearing. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 900 Lines: 30 On Tue, Jun 21, 2011 at 01:22:55AM +0200, Lars-Peter Clausen wrote: > On 06/20/2011 02:54 PM, Mark Brown wrote: > > [...] > > + > > +#include > > +#include > #include For...? > > +static int regmap_i2c_read(struct device *dev, > > + const void *reg, size_t reg_size, > > + void *val, size_t val_size) > > +{ > > + struct i2c_client *i2c = to_i2c_client(dev); > > + struct i2c_msg xfer[2]; > > + int ret; > > + if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_PROTOCOL_MANGLING)) > > + return -ENOTSUPP; > You shouldn't need I2C_FUNC_PROTOCOL_MANGLING for reading. Hrm, yeah, probably not. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/