Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932106Ab1FUBKn (ORCPT ); Mon, 20 Jun 2011 21:10:43 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:52991 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932069Ab1FUBKm (ORCPT ); Mon, 20 Jun 2011 21:10:42 -0400 Date: Tue, 21 Jun 2011 02:10:39 +0100 From: Mark Brown To: Peter Hsiang Cc: Taylor Hutt , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Olof Johansson , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC: codecs: Max98095: Fix logging of hardware revision. Message-ID: <20110621011038.GA4322@opensource.wolfsonmicro.com> References: <1308596072-17158-1-git-send-email-thutt@chromium.org> <20110621002322.GE1905@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: You're at the end of the road again. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 14 On Mon, Jun 20, 2011 at 05:43:58PM -0700, Peter Hsiang wrote: > I checked with hardware engineering and was told 0x40=RevA, 0x41=RevB.. > Would a raw value or the use of a 0x3F bit mask be more acceptable? I don't mind (though it does seem like the high bit isn't part of the actual data), it was just that it's a common error to assume that die revisions and package revisions correspond directly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/