Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755608Ab1FUDYQ (ORCPT ); Mon, 20 Jun 2011 23:24:16 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:50187 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752840Ab1FUDYO (ORCPT ); Mon, 20 Jun 2011 23:24:14 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=GXj+kOurkNTn00zReQEmxxuRp1CLdcqATZHRu0evMdFCYdyKaJSTsKpyNH0WqskIBF 6mLkaAKQHSh6gJjCa8LjD8IWBawDXlvpCG69MEEEY5nOWV+e/vgjgDC3uxbSCnKz9hDm ONdHt83ChYBOO0+uDaMU0byd4x3OZtzBNzeHA= MIME-Version: 1.0 In-Reply-To: <20110620081937.GN2611@htj.dyndns.org> References: <20110617120704.GH2611@htj.dyndns.org> <1308557202-1895-1-git-send-email-yuanlmm@gmail.com> <20110620081937.GN2611@htj.dyndns.org> Date: Tue, 21 Jun 2011 11:24:12 +0800 Message-ID: Subject: Re: [PATCH v4] ahci: move ahci_sb600_softreset to libahci.c and rename it From: Yuan-Hsin Chen To: Tejun Heo Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, sshtylyov@mvista.com, Yuan-Hsin Chen Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 20 Hello, Tejun. On Mon, Jun 20, 2011 at 4:19 PM, Tejun Heo wrote: >> +static int ahci_pmp_check_ready(struct ata_link *link) > > It would be better if the name reflects that it's not for specific > workaround. Do you mean it would be better to name it for specific workaround? How about ahci_bad_pmp_check_ready? Because this function is to avoid checking TFDATA if BAD PMP is found. Thanks. Yuan-Hsin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/