Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752875Ab1FUHED (ORCPT ); Tue, 21 Jun 2011 03:04:03 -0400 Received: from smtp2.kfki.hu ([148.6.0.28]:59484 "EHLO smtp2.kfki.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266Ab1FUHD6 (ORCPT ); Tue, 21 Jun 2011 03:03:58 -0400 X-Greylist: delayed 331 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Jun 2011 03:03:58 EDT Date: Tue, 21 Jun 2011 08:58:24 +0200 (CEST) From: Jozsef Kadlecsik To: Jesper Juhl cc: netdev@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, Dmitry Kozlov , netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org, "David S. Miller" Subject: Re: [netfilter-core] [PATCH] Remove redundant linux/version.h includes from net/ In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1734 Lines: 44 On Tue, 21 Jun 2011, Jesper Juhl wrote: > It was suggested by "make versioncheck" that the follwing includes of > linux/version.h are redundant: > > /home/jj/src/linux-2.6/net/caif/caif_dev.c: 14 linux/version.h not needed. > /home/jj/src/linux-2.6/net/caif/chnl_net.c: 10 linux/version.h not needed. > /home/jj/src/linux-2.6/net/ipv4/gre.c: 19 linux/version.h not needed. > /home/jj/src/linux-2.6/net/netfilter/ipset/ip_set_core.c: 20 linux/version.h not needed. > /home/jj/src/linux-2.6/net/netfilter/xt_set.c: 16 linux/version.h not needed. > > and it seems that it is right. > > Beyond manually inspecting the source files I also did a few build > tests with various configs to confirm that including the header in > those files is indeed not needed. > > Here's a patch to remove the pointless includes. > > Signed-off-by: Jesper Juhl > --- > net/caif/caif_dev.c | 1 - > net/caif/chnl_net.c | 1 - > net/ipv4/gre.c | 1 - > net/netfilter/ipset/ip_set_core.c | 1 - > net/netfilter/xt_set.c | 1 - > 5 files changed, 0 insertions(+), 5 deletions(-) For ipset/xt_set.c: Acked-by: Jozsef Kadlecsik Best regards, Jozsef - E-mail : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : KFKI Research Institute for Particle and Nuclear Physics H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/