Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280Ab1FUSY2 (ORCPT ); Tue, 21 Jun 2011 14:24:28 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:44438 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144Ab1FUSY0 (ORCPT ); Tue, 21 Jun 2011 14:24:26 -0400 MIME-Version: 1.0 In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF049D2EB8AD@HQMAIL01.nvidia.com> References: <20110621002318.8086.48367.stgit@riker> <74CDBE0F657A3D45AFBB94109FB122FF049D2EB8AD@HQMAIL01.nvidia.com> From: Grant Likely Date: Tue, 21 Jun 2011 12:24:05 -0600 X-Google-Sender-Auth: uYfNIRRpH4oRLF6xBMVAHR8SVwA Message-ID: Subject: Re: [PATCH] ARM: Tegra: i2c driver To: Stephen Warren Cc: John Bonesio , Ken Radtke , "lucas.demarchi@profusion.mobi" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Rakesh Iyer , "linux-i2c@vger.kernel.org" , "ben-linux@fluff.org" , "khali@linux-fr.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 31 On Tue, Jun 21, 2011 at 11:27 AM, Stephen Warren wrote: > John Bonesio wrote at Monday, June 20, 2011 6:23 PM: >> This patch modifies the tegra i2c driver so that it can be initiailized >> using the device tree along with the devices connected to the i2c bus. > > The patch title "ARM: Tegra: i2c driver" doesn't really describe what the > patch does and has the wrong tag; It sounds like adding a new driver. > Perhaps "i2c: Tegra: Add DeviceTree support"? Yes, sounds appropriate to me. g. > > The code looks fine. > > -- > nvpublic > > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/