Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756944Ab1FUWcU (ORCPT ); Tue, 21 Jun 2011 18:32:20 -0400 Received: from mail127.messagelabs.com ([216.82.250.115]:61500 "EHLO mail127.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752468Ab1FUWcR convert rfc822-to-8bit (ORCPT ); Tue, 21 Jun 2011 18:32:17 -0400 X-VirusChecked: Checked X-Env-Sender: hartleys@visionengravers.com X-Msg-Ref: server-10.tower-127.messagelabs.com!1308695488!9055035!49 X-StarScan-Version: 6.2.17; banners=-,-,- X-Originating-IP: [216.166.12.178] From: H Hartley Sweeten To: Mike Frysinger CC: Linux Kernel , ARM Kernel , Russell King , "mikpe@it.uu.se" , "ebiederm@xmission.com" , "tony.luck@intel.com" Date: Tue, 21 Jun 2011 17:32:04 -0500 Subject: RE: [PATCH] ARM: quiet sparse noise due to __ARCH_WANT_SYS_RT_SIG(ACTION|SUSPEND) Thread-Topic: [PATCH] ARM: quiet sparse noise due to __ARCH_WANT_SYS_RT_SIG(ACTION|SUSPEND) Thread-Index: AcwwSdn7kwMZxo4HT3er/augjch+wwAGIRYg Message-ID: References: <201106211209.46462.hartleys@visionengravers.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2013 Lines: 61 On Tuesday, June 21, 2011 12:31 PM, Mike Frysinger wrote: > On Tue, Jun 21, 2011 at 15:09, H Hartley Sweeten wrote: >> --- a/arch/arm/include/asm/unistd.h >> +++ b/arch/arm/include/asm/unistd.h >> @@ -467,6 +467,20 @@ >> +#ifndef __ASSEMBLY__ >> + >> +#include >> +#include >> +#include >> +#include >> + >> +asmlinkage long sys_rt_sigaction(int sig, const struct sigaction __user *act, >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct sigaction __user *oact, >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?size_t sigsetsize); >> +asmlinkage long sys_rt_sigsuspend(sigset_t __user *unewset, size_t sigsetsize); >> + >> +#endif /* !__ASSEMBLY__ */ > > yikes ... this really the only way to fix the sparse warning ? Not sure... Russell's patch to add an asm/syscalls.h fixes the other system call sparse warnings in arm/arm/kernel/* but it doesn't fix the ones in kernel/signal.c. This patch does but, as Russell said, asm/unistd.h is exported to it's a bit ugly. BTW, arch/ia64 does something very similar: #if !defined(__ASSEMBLY__) && !defined(ASSEMBLER) #include #include #include extern long __ia64_syscall (long a0, long a1, long a2, long a3, long a4, long nr); asmlinkage unsigned long sys_mmap( unsigned long addr, unsigned long len, int prot, int flags, int fd, long off); asmlinkage unsigned long sys_mmap2( unsigned long addr, unsigned long len, int prot, int flags, int fd, long pgoff); struct pt_regs; struct sigaction; asmlinkage long sys_ia64_pipe(void); asmlinkage long sys_rt_sigaction(int sig, const struct sigaction __user *act, struct sigaction __user *oact, size_t sigsetsize); Regards, Hartley-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/