Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757220Ab1FUWoW (ORCPT ); Tue, 21 Jun 2011 18:44:22 -0400 Received: from fieldses.org ([174.143.236.118]:41381 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756665Ab1FUWoU (ORCPT ); Tue, 21 Jun 2011 18:44:20 -0400 Date: Tue, 21 Jun 2011 18:44:18 -0400 From: "J. Bruce Fields" To: H Hartley Sweeten Cc: Linux Kernel , netdev@vger.kernel.org, linux-nfs@vger.kernel.org, Trond.Myklebust@netapp.com, neilb@suse.de, davem@davemloft.net Subject: Re: [PATCH] svcsock.c: include sunrpc.h to quite sparse noise Message-ID: <20110621224418.GB28047@fieldses.org> References: <201106201754.51704.hartleys@visionengravers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201106201754.51704.hartleys@visionengravers.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 35 On Mon, Jun 20, 2011 at 05:54:51PM -0700, H Hartley Sweeten wrote: > Include the private header sunrpc.h to pickup the declaration of the > function svc_send_common to quiet the following sparse noise: > > warning: symbol 'svc_send_common' was not declared. Should it be static? Thanks, applying for 3.1--b. > > Signed-off-by: H Hartley Sweeten > Cc: Trond Myklebust > Cc: "J. Bruce Fields" > Cc: Neil Brown > Cc: "David S. Miller" > > --- > > diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c > index af04f77..f2cb5b8 100644 > --- a/net/sunrpc/svcsock.c > +++ b/net/sunrpc/svcsock.c > @@ -51,6 +51,8 @@ > #include > #include > > +#include "sunrpc.h" > + > #define RPCDBG_FACILITY RPCDBG_SVCXPRT > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/