Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757800Ab1FVDnp (ORCPT ); Tue, 21 Jun 2011 23:43:45 -0400 Received: from mail-qy0-f181.google.com ([209.85.216.181]:54125 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757493Ab1FVDno (ORCPT ); Tue, 21 Jun 2011 23:43:44 -0400 Message-ID: <4E0164E8.8060708@linaro.org> Date: Wed, 22 Jun 2011 09:13:36 +0530 From: Tushar Behera User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110516 Thunderbird/3.1.10 MIME-Version: 1.0 To: myungjoo.ham@gmail.com CC: MyungJoo Ham , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King , Kyungmin Park , Kukjin Kim , Mark Brown , dg77.kim@samsung.com Subject: Re: [PATCH v2 1/4] Exynos4 NURI: configure regulators and PMIC References: <20110620103124.GD31864@opensource.wolfsonmicro.com> <1308622033-2521-1-git-send-email-myungjoo.ham@samsung.com> <1308622033-2521-2-git-send-email-myungjoo.ham@samsung.com> <4E002D18.2080401@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1734 Lines: 49 On Wednesday 22 June 2011 08:01 AM, MyungJoo Ham wrote: > On Tue, Jun 21, 2011 at 2:33 PM, Tushar Behera wrote: >> On Tuesday 21 June 2011 07:37 AM, MyungJoo Ham wrote: >>> >>> Signed-off-by: MyungJoo Ham >>> Signed-off-by: Kyungmin Park >>> >>> -- >>> Changes from v1. Thanks so much for your valuable comments, Mark. >>> - Removed unnecessary initialization data >>> - Add __initdata where necessary >>> - Corrected a regulator name for ADC >>> --- >>> arch/arm/mach-exynos4/mach-nuri.c | 622 >>> ++++++++++++++++++++++++++++++++++++- >>> 1 files changed, 621 insertions(+), 1 deletions(-) >>> >> Will it be possible to move PMIC specific defines to a common file and make >> appropriate calls in the board-specific file? >> >> In that way, we can re-use this PMIC code on some other boards (e.g. >> Insignal low-cost board Origen featuring Exynos4210 also features MAX8997). >> > > Yes, we have tried creating PMIC defines at a seperated file in our > local repositories (still doing so in those repositories). > However, that ended up creating multiple PMIC defines (one PMIC define > file for each board); the connections between LDO# and devices are > different. > In that case, we can first post the Origen board support and PMIC code on the ML, then we would see if we can consolidate. That looks more logical as per Mark's suggestion also. >> >> -- >> Tushar Behera >> > > -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/