Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753798Ab1FVJQH (ORCPT ); Wed, 22 Jun 2011 05:16:07 -0400 Received: from webbox687.server-home.net ([195.149.74.151]:37738 "EHLO webbox687.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007Ab1FVJQF (ORCPT ); Wed, 22 Jun 2011 05:16:05 -0400 From: Alexander Stein To: Tomoya MORINAGA Subject: Re: [PATCH v3] pch_gpio: Support interrupt function Date: Wed, 22 Jun 2011 11:15:31 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.38-gentoo-r6; KDE/4.6.3; x86_64; ; ) Cc: Grant Likely , linux-kernel@vger.kernel.org, qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com, kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com References: <1308631468-2376-1-git-send-email-tomoya-linux@dsn.okisemi.com> <201106220828.30516.alexander.stein@systec-electronic.com> <4E01A452.8060801@dsn.okisemi.com> In-Reply-To: <4E01A452.8060801@dsn.okisemi.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106221115.31885.alexander.stein@systec-electronic.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1594 Lines: 36 On Wednesday 22 June 2011 10:14:10 Tomoya MORINAGA wrote: > (2011/06/22 15:28), Alexander Stein wrote: > > On Wednesday 22 June 2011 02:10:28 Tomoya MORINAGA wrote: > >> (2011/06/21 18:10), Alexander Stein wrote: > >>> I wrote a small program which use poll(2) on value, after edge hase > >>> been configured from shell. I cannot test the edge detection > >>> appropriately due to debouncing using jumpers. > >> > >> Really ? > >> In out test environment, my test program could detect edge interrupt > >> correctly. > > > > My test program used poll/select on edge successfully. But I could not > > test the raising or falling feature actually, as my input is bouncing. > > So, it doesn't matter if I set both/raising/falling in edge, due to my > > inputs the effect is the same. Any input event will end in several > > raising and falling interrupts events. > > I hope I could make this more clear. > > Our test program also uses poll (We don't use select().) I noticed poll/select work nearly as the same. Both worked fine here. > BTW, is the above your saying related to your patch "[PATCH] pch_gpio: > transform mutex into spinlock" ? Should be unrelated. I did the GPIO interrupt test before stumbling on the mutex/spinlock problem. The latter one was caused by setting a GPIO from interrupt context (in a different driver). Alexander -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/