Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755518Ab1FVJbS (ORCPT ); Wed, 22 Jun 2011 05:31:18 -0400 Received: from mail-qy0-f174.google.com ([209.85.216.174]:58462 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754242Ab1FVJbR convert rfc822-to-8bit (ORCPT ); Wed, 22 Jun 2011 05:31:17 -0400 MIME-Version: 1.0 In-Reply-To: References: <1308699521-20556-1-git-send-email-per.forlin@linaro.org> <1308699521-20556-3-git-send-email-per.forlin@linaro.org> Date: Wed, 22 Jun 2011 11:31:16 +0200 Message-ID: Subject: Re: [PATCH v7 02/11] omap_hsmmc: add support for pre_req and post_req From: Per Forlin To: Nickolay Nickolaev Cc: linaro-dev@lists.linaro.org, Nicolas Pitre , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Venkatraman S Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1245 Lines: 40 On 22 June 2011 10:51, Nickolay Nickolaev wrote: > Hello, > > this one's causing me compilation trouble troubles when CONFIG_DMA_ENGINE is > not defined. > I don't see this issue when I compile the kernel for a Pandaboard without CONFIG_DMA_ENGINE being set. Could you please clarify or show me your build log? I don't see how host->next_data.cookie is connected to DMA_ENGINE. > On Wed, Jun 22, 2011 at 2:38 AM, Per Forlin wrote: >> >> @@ -2077,6 +2155,7 @@ static int __init omap_hsmmc_probe(struct >> platform_device *pdev) >> ? ? ? ?host->mapbase ? = res->start; >> ? ? ? ?host->base ? ? ?= ioremap(host->mapbase, SZ_4K); >> ? ? ? ?host->power_mode = MMC_POWER_OFF; >> + ? ? ? host->next_data.cookie = 1; >> >> ? ? ? ?platform_set_drvdata(pdev, host); >> ? ? ? ?INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect); >> -- >> 1.7.4.1 >> >> > > Maybe we can wrap it in a function as the others. > > regards, > Nikolay Nikolaev > Regards, Per -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/