Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757250Ab1FVLI5 (ORCPT ); Wed, 22 Jun 2011 07:08:57 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:45381 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756158Ab1FVLIw (ORCPT ); Wed, 22 Jun 2011 07:08:52 -0400 Date: Wed, 22 Jun 2011 12:08:49 +0100 From: Mark Brown To: myungjoo.ham@gmail.com Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King , Kyungmin Park , Kukjin Kim , dg77.kim@samsung.com Subject: Re: [PATCH v2 4/4] Exynos4 NURI: support for NTC thermistor Message-ID: <20110622110848.GA18726@opensource.wolfsonmicro.com> References: <20110620103124.GD31864@opensource.wolfsonmicro.com> <1308622033-2521-1-git-send-email-myungjoo.ham@samsung.com> <1308622033-2521-5-git-send-email-myungjoo.ham@samsung.com> <20110621105033.GF22177@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Cookie: Your present plans will be successful. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1781 Lines: 43 On Wed, Jun 22, 2011 at 02:00:37PM +0900, MyungJoo Ham wrote: > On Tue, Jun 21, 2011 at 7:50 PM, Mark Brown > >> +#include > > This doesn't appear to be in mainline. > Right, not just yet. I should've added comment about the patch just > being applied to "next". I was actually looking at -next rather than Linus' tree there... > Should I surround them with "#ifdef CONFIG_NTC_THERMISTOR"? I guess, or just wait until it gets merged. > > Why not do this in an initcall or in the device registration? ?This > > looks like working around a limitation of the ntc_thermistor driver > > which should be fixed as part of a mainline merge for that. > Um... I think I can put this away to a common plat-samsung/dev-ntc.c > as I've seen many S5PC110/S5PV210/Exynos4 devices using NTC attached > to the CPU's ADC ports. Yes, but it's not just the location of the code - I was mostly noticing the fact that it was doing something that's clearly supposed to be a probe() method in the main read function. It'd be better if there were an explicit probe() and corresponding remove() interface. I also note that this callback based stuff won't work terribly well with device tree. > However, I won't be able to put that part into the NTC driver because > using S3C-ADC is plat-samsung specific method and NTC thermistor > itself is a general thermistor device not specific to S3C. Maybe, I > can do so after we've got a common ADC framework. Yes, we really need to get that ADC stuff sorted soon :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/