Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758725Ab1FWCi2 (ORCPT ); Wed, 22 Jun 2011 22:38:28 -0400 Received: from mga14.intel.com ([143.182.124.37]:35981 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758113Ab1FWCi1 (ORCPT ); Wed, 22 Jun 2011 22:38:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,410,1304319600"; d="scan'208";a="17204440" Date: Thu, 23 Jun 2011 10:45:06 +0800 From: Feng Tang To: "dirk.brandewie@gmail.com" CC: "linux-kernel@vger.kernel.org" , "spi-devel-general@lists.sourceforge.net" Subject: Re: [PATCH 09/11] spi-dw: Fix condition in spi_dw_{writer/reader} Message-ID: <20110623104506.3cfd55ce@feng-i7> In-Reply-To: <1308794413-11069-10-git-send-email-dirk.brandewie@gmail.com> References: <1308794413-11069-1-git-send-email-dirk.brandewie@gmail.com> <1308794413-11069-10-git-send-email-dirk.brandewie@gmail.com> Organization: intel X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.0; i486-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1691 Lines: 51 On Thu, 23 Jun 2011 10:00:11 +0800 "dirk.brandewie@gmail.com" wrote: > From: Dirk Brandewie > > Fix the condition based on whether the current transfer has a tx/rx > buffer. > > Signed-off-by: Dirk Brandewie > --- > drivers/spi/spi-dw.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c > index cc38aa0..35b952b 100644 > --- a/drivers/spi/spi-dw.c > +++ b/drivers/spi/spi-dw.c > @@ -193,8 +193,8 @@ static void spi_dw_writer(struct spi_dw *dws) > u16 txw = 0; > > while (max--) { > - /* Set the tx word if the transfer's original "tx" > is not null */ > - if (dws->tx_end - dws->len) { > + /* Set the tx word if the transfer's "tx" is not > null */ > + if (dws->tx) { No, in current mainstream code, the dws->tx is changing, see code: dws->tx += dws->n_bytes; so we have to use if (dws->tx_end - dws->len) for now, maybe we can use some bit to indicate whether the original tx is null > if (dws->n_bytes == 1) > txw = *(u8 *)(dws->tx); > else > @@ -213,7 +213,7 @@ static void spi_dw_reader(struct spi_dw *dws) > while (max--) { > rxw = dw_readw(dws, dr); > /* Care rx only if the transfer's original "rx" is > not null */ > - if (dws->rx_end - dws->len) { > + if (dws->rx) { > if (dws->n_bytes == 1) > *(u8 *)(dws->rx) = rxw; > else -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/