Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753577Ab1FWFKc (ORCPT ); Thu, 23 Jun 2011 01:10:32 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:57033 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058Ab1FWFKa (ORCPT ); Thu, 23 Jun 2011 01:10:30 -0400 Subject: Re: [PATCH] libata/sas: only set FROZEN flag if new EH is supported From: Benjamin Herrenschmidt To: Brian King Cc: Nishanth Aravamudan , Tejun Heo , linuxppc-dev@lists.ozlabs.org, wayneb@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, mbizon@freebox.fr, jgarzik@pobox.com In-Reply-To: <1308804120.32158.202.camel@pasglop> References: <20110615191747.GA6324@us.ibm.com> <4DF90FCA.1040706@linux.vnet.ibm.com> <20110615233417.GB6324@us.ibm.com> <20110616075114.GH8141@htj.dyndns.org> <4DFA0507.3090609@linux.vnet.ibm.com> <20110616152836.GA15268@us.ibm.com> <20110621160714.GA14174@us.ibm.com> <4E00FF58.7070802@linux.vnet.ibm.com> <1308803461.32158.191.camel@pasglop> <1308804120.32158.202.camel@pasglop> Content-Type: text/plain; charset="UTF-8" Organization: IBM Australia Date: Thu, 23 Jun 2011 15:10:17 +1000 Message-ID: <1308805817.32158.204.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 27 On Thu, 2011-06-23 at 14:42 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2011-06-23 at 14:31 +1000, Benjamin Herrenschmidt wrote: > > On Tue, 2011-06-21 at 15:30 -0500, Brian King wrote: > > > Looks good to me. Jeff/Tejun - any issues with merging this? > > > > BTW. Current upstream with that patch applied on a machine here leads to > > several oddities, I don't know at this point whether any of that is > > actually a regression : > > Ooops... pressed "send" too quickly. Here's a log excerpt with some > comments: .../... Ok so most of that is already in 2.6.39, including the odd LUN, so nothing new under the sun. I'll do more digging / bisection... Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/