Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759271Ab1FWLY2 (ORCPT ); Thu, 23 Jun 2011 07:24:28 -0400 Received: from mail-vx0-f174.google.com ([209.85.220.174]:35807 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756339Ab1FWLY1 convert rfc822-to-8bit (ORCPT ); Thu, 23 Jun 2011 07:24:27 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=vrfy.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=P9Zl5j+tjZUU1mi/bQ9NpruNhmd7X8aQMNNRDx0JX0euCItWhH5NRkKmYxWbEC7QBJ OmWMwZUfFYfFYGItZvFz0aq1WPRgONJQMPXe+SjPwGl8t6gZYNkPniRTYasYcC7ouEQz dzUYGmRfPCyeUKHfkJ3h5sYg8IQOkG4r6C9iI= MIME-Version: 1.0 In-Reply-To: <87fwn18k9h.fsf@rustcorp.com.au> References: <1308434431.1050.5.camel@mop> <8739j59zib.fsf@rustcorp.com.au> <87boxshrwe.fsf@rustcorp.com.au> <87r56m8w2b.fsf@rustcorp.com.au> <87fwn18k9h.fsf@rustcorp.com.au> From: Kay Sievers Date: Thu, 23 Jun 2011 13:24:06 +0200 Message-ID: Subject: Re: module: sysfs - add 'uevent' file to allow coldplug To: Rusty Russell Cc: linux-kernel , Greg KH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1378 Lines: 31 On Thu, Jun 23, 2011 at 02:27, Rusty Russell wrote: > On Wed, 22 Jun 2011 12:17:49 +0200, Kay Sievers wrote: >> On Wed, Jun 22, 2011 at 04:00, Rusty Russell wrote: >> > Now we've got that sorted, is there a reason why you changed all the >> > signatures rather than just using mod->mkobj in store_uevent()? >> >> Because we should be able to use the same 'struct module_attribute' >> for built-in modules and for loaded modules at the same time. The >> current 'struct module_attribute' has 'struct module' references, but >> 'struct module' will never exist for built-in modules. >> >> 'Struct module_kobject' has nice back-pointer to 'struct module', so >> this was the simplest to do, and looks still fine, I thought. > > Yes, it's weird.  The only reason it currently works is because we don't > use the mod parameter in param_attr_show and param_attr_store; it's NULL > for built-in modules. > > I'd prefer that patch first, I think: it's a sensible cleanup. You want the patch split up in two? You want to remove the mod parameter somehow? Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/