Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932380Ab1FWPHC (ORCPT ); Thu, 23 Jun 2011 11:07:02 -0400 Received: from h5.dl5rb.org.uk ([81.2.74.5]:36282 "EHLO duck.linux-mips.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758983Ab1FWPHA (ORCPT ); Thu, 23 Jun 2011 11:07:00 -0400 Date: Thu, 23 Jun 2011 16:05:57 +0100 From: Ralf Baechle To: Kumar Gala Cc: Martyn Welch , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, David Howells , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, linux-am33-list@redhat.com, Paul Mundt , linux-sh@vger.kernel.org, Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-arch@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , "linuxppc-dev@lists.ozlabs.org Tony Luck" , Fenghua Yu , linux-ia64@vger.kernel.org Subject: Re: [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE Message-ID: <20110623150557.GA9258@linux-mips.org> References: <20110623114536.GA14011@linux-mips.org> <4E032940.5010205@ge.com> <20110623120234.GA22524@linux-mips.org> <8B77EED3-D197-4AB9-9594-278DB7002D6D@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8B77EED3-D197-4AB9-9594-278DB7002D6D@kernel.crashing.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 31 On Thu, Jun 23, 2011 at 07:10:29AM -0500, Kumar Gala wrote: > > (Adding the PPC folks to cc.) > > > > A "git grep -w PAGE_KERNEL_NOCACHE arch/powerpc/" doesn't find anything so > > I don't think the driver will build there. I don't have a PPC toolchain > > to verify that. > > I can verify it fails on PPC as well: > > drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc': > drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function) > drivers/staging/comedi/drivers.c:505:37: note: each undeclared identifier is reported only once for each function it appears in > > However, we do have a #define for PAGE_KERNEL_NC. Do you think this driver in it's current stage is so valuable that some ifdefery to get it to work on PPC is the way to go? IA-64 has PAGE_KERNEL_UC, so basically the same question for IA-64, too. But preferably the driver should be sorted out properly and until the v1 of my patch which disables it on all architectures that don't provide a PAGE_KERNEL_NOCACHE definition will do just fine. Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/