DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=ptlaA8tQGHgJHUxgD/cJOWDSguxqwyRgOMpoRiZWW6hJrrl8P13iTtMIfkx/A2cCzC
         rFFBDjrg/RXQKcZV4ClWaYkhOHGZIp4YTZGKdc6deqtdRsErZrC7uyFoz7NOVDmn0mX9
         cVF3bHXa/4Jk7ji36K4gl3a74j7ZlLeFHb/5s=
MIME-Version: 1.0
In-Reply-To: <20110622190739.GB14351@albatros>
References: <20110622095341.GA3353@albatros>
	<1308760683.10423.16.camel@Joe-Laptop>
	<20110622191022.66135615@lxorguk.ukuu.org.uk>
	<20110622190739.GB14351@albatros>
Date: Thu, 23 Jun 2011 20:11:46 +0200
Message-ID: <BANLkTimQxzqstxLnO-_dDMoRbWbGPQJrvA@mail.gmail.com>
Subject: Re: [PATCH] kernel: escape non-ASCII and control characters in printk()
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Joe Perches <joe@perches.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        James Morris <jmorris@namei.org>, Ingo Molnar <mingo@elte.hu>,
        Namhyung Kim <namhyung@gmail.com>, Greg Kroah-Hartman <gregkh@suse.de>,
        kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org,
        security@kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1246
Lines: 31

On Wed, Jun 22, 2011 at 21:07, Vasiliy Kulikov <segoon@openwall.com> wrote:
> On Wed, Jun 22, 2011 at 19:10 +0100, Alan Cox wrote:
>> If that is set you shouldn't be filtering out unicode, just control codes.
>
> OK.
>
>> Minor other nit is that you might want to allow BEL through and you
>> certainly want to allow tab through.
>
> In what situation do you think BEL makes sense in kernel log?  I cannot
> image the situation.  Alarms should use KERN_EMERG/KERN_ALERT log level.

Does BEL work? Last time I tried fancy things (e.g. color output
depending on the
message level), it didn't work. I only got strange characters.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/