Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751603Ab1FXEFX (ORCPT ); Fri, 24 Jun 2011 00:05:23 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:56508 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752Ab1FXEFV convert rfc822-to-8bit (ORCPT ); Fri, 24 Jun 2011 00:05:21 -0400 MIME-Version: 1.0 In-Reply-To: <20110624034859.GB19188@S2100-06.ap.freescale.net> References: <1308410354-21387-1-git-send-email-shawn.guo@linaro.org> <1308410354-21387-2-git-send-email-shawn.guo@linaro.org> <20110618161934.GH8195@ponder.secretlab.ca> <20110619073000.GA23171@S2100-06.ap.freescale.net> <20110621135558.GB9228@S2101-09.ap.freescale.net> <20110623183821.GA19188@S2100-06.ap.freescale.net> <20110624034859.GB19188@S2100-06.ap.freescale.net> From: Grant Likely Date: Thu, 23 Jun 2011 22:05:00 -0600 X-Google-Sender-Auth: VzM-b-mh53OAvBFOIfjU44nJ4eE Message-ID: Subject: Re: [PATCH 1/3] serial/imx: add device tree support To: Shawn Guo Cc: patches@linaro.org, netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Jason Liu , linux-kernel@vger.kernel.org, Jeremy Kerr , Sascha Hauer , linux-arm-kernel@lists.infradead.org, David Gibson Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 25 On Thu, Jun 23, 2011 at 9:49 PM, Shawn Guo wrote: > On Thu, Jun 23, 2011 at 05:11:54PM -0600, Grant Likely wrote: >> > + ? ? ? ? ? ? ? int devid = get_alias_name_id(pp->name, devname); >> > + >> > + ? ? ? ? ? ? ? /* We do not want to proceed this sentinel one */ >> > + ? ? ? ? ? ? ? if (!strcmp(pp->name, "name") && !strcmp(pp->value, "aliases")) >> > + ? ? ? ? ? ? ? ? ? ? ? break; >> >> Skipping the 'name' property is good, but I don't think you need to >> check the value. ?You should also skip the "phandle" property. >> > Ok. I have not seen "phandle" property in aliases node though. ?Can > you give me an example, so that I can make one up for testing? It's a standard property that shows up automatically if any node happens to have a phandle reference to another node. The name will be either "phandle" or "linux,phandle". Search for "linux,phandle" in drivers/of/fdt.c to see how that property is processed. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/