Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914Ab1FXIPR (ORCPT ); Fri, 24 Jun 2011 04:15:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13087 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753624Ab1FXIPO (ORCPT ); Fri, 24 Jun 2011 04:15:14 -0400 Date: Fri, 24 Jun 2011 10:16:53 +0200 From: Stanislaw Gruszka To: Paul Gortmaker Cc: stable@kernel.org, linux-kernel@vger.kernel.org, stable-review@kernel.org, "John W. Linville" Subject: Re: [34-longterm 029/247] iwlagn: enable only rfkill interrupt when device is down Message-ID: <20110624081649.GA2190@redhat.com> References: <1308849690-14530-1-git-send-email-paul.gortmaker@windriver.com> <1308849690-14530-30-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1308849690-14530-30-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1550 Lines: 38 On Thu, Jun 23, 2011 at 01:17:52PM -0400, Paul Gortmaker wrote: > From: Stanislaw Gruszka > > ------------------- > This is a commit scheduled for the next v2.6.34 longterm release. > If you see a problem with using this for longterm, please comment. > ------------------- > > commit 554d1d027b19265c4aa3f718b3126d2b86e09a08 upstream. > > Since commit 6cd0b1cb872b3bf9fc5de4536404206ab74bafdd "iwlagn: fix > hw-rfkill while the interface is down", we enable interrupts when > device is not ready to receive them. However hardware, when it is in > some inconsistent state, can generate other than rfkill interrupts > and crash the system. I can reproduce crash with "kernel BUG at > drivers/net/wireless/iwlwifi/iwl-agn.c:1010!" message, when forcing > firmware restarts. > > To fix only enable rfkill interrupt when down device and after probe. > I checked patch on laptop with 5100 device, rfkill change is still > passed to user space when device is down. This needs follow up: commit 3dd823e6b86407aed1a025041d8f1df77e43a9c8 Author: Don Fry Date: Sun Feb 6 09:29:45 2011 -0800 iwlagn: Re-enable RF_KILL interrupt when down I'm not sure if that commit is included in the patch series. Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/