Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753634Ab1FXNH3 (ORCPT ); Fri, 24 Jun 2011 09:07:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:32955 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701Ab1FXNH2 (ORCPT ); Fri, 24 Jun 2011 09:07:28 -0400 Message-ID: <4E048C0D.7020403@suse.cz> Date: Fri, 24 Jun 2011 15:07:25 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 To: Joe Perches Cc: Markus Trippelsdorf , Nick Bowler , "linux-kernel@vger.kernel.org" , Mike Frysinger , Sam Ravnborg , Artem Bityutskiy Subject: Re: __packed vs. __attribute__((packed)) in kernel headers References: <20110622063441.GA1740@x4.trippels.de> <20110623134209.GA10813@elliptictech.com> <20110623150209.GA12413@x4.trippels.de> <1308848277.6688.7.camel@Joe-Laptop> In-Reply-To: <1308848277.6688.7.camel@Joe-Laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1188 Lines: 32 On 23.6.2011 18:57, Joe Perches wrote: > On Thu, 2011-06-23 at 17:02 +0200, Markus Trippelsdorf wrote: >> On 2011.06.23 at 09:42 -0400, Nick Bowler wrote: >>> On 2011-06-22 08:34 +0200, Markus Trippelsdorf wrote: >>>> One possible solution would be to let the "scripts/headers_install.pl" >>>> script automatically substitute __packed with __attribute__((packed)): >>>> >>>> diff --git a/scripts/headers_install.pl b/scripts/headers_install.pl > [] >> I'm not an expert of Perl regular expressions, but maybe this: >> $line =~ s/\s__packed;$/ __attribute__((packed));/g >> is a little bit closer to the intention? > > Maybe: > > s/\b__packed\b/__attribute__((packed))/g Markus, will you post a patch with this fix? > though this argues against redefining > gcc __attributes__ in the first place. It's a handy shortcut, so why not have it. Although I don't understand why checkpatch.pl has to warn about __attribute__((packed)). Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/